Skip to content

Improve Base16 Codebase #3534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 23, 2020
Merged

Improve Base16 Codebase #3534

merged 2 commits into from
Nov 23, 2020

Conversation

tanyonghe
Copy link
Contributor

@tanyonghe tanyonghe commented Oct 19, 2020 •
edited
Loading

Changes:

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Used to mark an issue or pull request stale. label Nov 18, 2020
@dhruvmanila
Copy link
Member

Remove the label.

@stale stale bot removed the stale Used to mark an issue or pull request stale. label Nov 23, 2020
@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Nov 23, 2020
dhruvmanila
dhruvmanila requested changes Nov 23, 2020
View reviewed changes
@ghost ghost added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Nov 23, 2020
dhruvmanila
dhruvmanila approved these changes Nov 23, 2020
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@ghost ghost removed the awaiting changes A maintainer has requested changes to this PR label Nov 23, 2020
@dhruvmanila dhruvmanila merged commit 9bf7b18 into TheAlgorithms:master Nov 23, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@tanyonghe @dhruvmanila @stokhos
Improve Base16 Codebase (TheAlgorithms#3534)
8bc4603 
* Add doctest and remove input() usage

* Apply suggestions from code review

Co-authored-by: Dhruv Manilawala <[email protected]>
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@tanyonghe @dhruvmanila @peRFectBeliever
Improve Base16 Codebase (TheAlgorithms#3534)
e8c25b4 
* Add doctest and remove input() usage

* Apply suggestions from code review

Co-authored-by: Dhruv Manilawala <[email protected]>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@tanyonghe @dhruvmanila
Improve Base16 Codebase (TheAlgorithms#3534)
d637cf3 
* Add doctest and remove input() usage

* Apply suggestions from code review

Co-authored-by: Dhruv Manilawala <[email protected]>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@tanyonghe @dhruvmanila @shermanhui
Improve Base16 Codebase (TheAlgorithms#3534)
60aca93 
* Add doctest and remove input() usage

* Apply suggestions from code review

Co-authored-by: Dhruv Manilawala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanyonghe @dhruvmanila